Skip to content

rocSPARSE SpSV by generic API#58

Open
yhmtsai wants to merge 3 commits intomainfrom
dev/yhmtsai/rocsparse_spsv
Open

rocSPARSE SpSV by generic API#58
yhmtsai wants to merge 3 commits intomainfrom
dev/yhmtsai/rocsparse_spsv

Conversation

@yhmtsai
Copy link
Copy Markdown
Contributor

@yhmtsai yhmtsai commented Aug 21, 2025

Summary:
It implements rocSPARSE SpSV from generic API.

Details:

  • create triangular_solver_state_t and corresponding implementation
  • have additional test for device spsv which already contains fix triangular solve test #57

Merge Checklist:

  • Passing CI
  • Update documentation or README.md
  • Additional Test/example added (if applicable) and passing
  • At least one reviewer approval
  • (optional) Clang sanitizer scan run and triaged
  • Clang formatter applied (verified as part of passing CI)

@yhmtsai yhmtsai self-assigned this Aug 21, 2025
@yhmtsai yhmtsai mentioned this pull request Aug 21, 2025
6 tasks
Base automatically changed from dev/yhmtsai/rocsparse_spgemm to main March 26, 2026 15:38
@yhmtsai yhmtsai force-pushed the dev/yhmtsai/rocsparse_spsv branch from 879a7d3 to 64d579a Compare April 10, 2026 12:59
@yhmtsai yhmtsai requested a review from spencerpatty April 10, 2026 13:00
std::span<T> b_span(d_b.data().get(), m);
std::span<T> x_span(d_x.data().get(), n);

spblas::triangular_solve_state_t state;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were using a single spblas::operation_state_t object for all cases, not specialized to the operations ?!?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right. At least need to have the interface for single operation_state_t.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I also record the potential issue in #72 #73. It should be solvable, so I will focus on the other stuff first

@yhmtsai
Copy link
Copy Markdown
Contributor Author

yhmtsai commented Apr 10, 2026

rocsparse is still failed in the ci. I guess it is library and driver mismatch and I am investigating it.
I have tested it on MI50 with ROCm/6.3.3 successfully.

@yhmtsai yhmtsai force-pushed the dev/yhmtsai/rocsparse_spsv branch from 824cfeb to 6708ba8 Compare April 13, 2026 12:47
@yhmtsai yhmtsai force-pushed the dev/yhmtsai/rocsparse_spsv branch from 6708ba8 to 88d5187 Compare April 15, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants